AdCOM v1.0-202607 - #27
Conversation
| // Media rating per IQG guidelines. | ||
| // Refer to List: Media Ratings. | ||
| MRating MediaRating `json:"mrating,omitempty"` | ||
| QAGMediaMRating MediaRating `json:"qagmediarating,omitempty"` |
There was a problem hiding this comment.
Many of the changes in this file look wrong. I see you copied them verbatim from the AdCOM spec, but there might be a problem with the spec. I'm looking into it.
There was a problem hiding this comment.
Regardless of the specs validity, this particular line contains a typo.
There was a problem hiding this comment.
I've confirmed these changes to the AdCOM spec were not intentional and were accidently updated to match OpenRTB naming. I'll revert those changes and then can you please update this PR?
There was a problem hiding this comment.
I pushed c6b2da5 based on the revert discussed in InteractiveAdvertisingBureau/AdCOM#97
This is great news because it mitigates the worst of the compatibility issues in the latest AdCOM version.
01a9ef5 to
c6b2da5
Compare
2 participants
Further reading
breaks compatiblity with previous module, and requires new module version (v21?)VideoPlacementSubtypeeven though it was deprecated in 2023