Repository navigation
Check identity with whoami and start waiting before submitting a sign-up - #52
Merged
Merged
Conversation
whoami is now the identity check, since Codex and manually selected profiles act as an agent without PRIMITIVE_AGENT_ADDRESS. The sign-up recipe starts primitive wait in the background before the form is submitted, because the wait only matches mail that arrives after it starts and a fast service can send the code first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from review of the vendored skill:
$PRIMITIVE_AGENT_ADDRESSas no identity, but Codex sessions and manually selected profiles act as an agent without it.primitive whoamiis now the check; its first line is the address for any agent identity.primitive waitafter submitting the form, andwaitonly matches mail that arrives after it starts, so a fast service's code could be missed. The recipe now starts the wait in the background first, then reads its result after submitting. The already-submitted case uses--include-existingand checks the arrival time with--json.Tests: all 83 pass; plugin manifests agree; SKILL.md stays under the 190-line limit (187).