Repository navigation
Parse hybrid-36 all-digit residue fields as decimal - #2281
Open
shaneraphel wants to merge 1 commit into
Open
shaneraphel wants to merge 1 commit into
shaneraphel wants to merge 1 commit into
Conversation
After the first leftover hybrid-36 letter, leftover isnumeric digits were leftover int(..., 16), so writePDB hybrid36 output did not round-trip.
shaneraphel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parsePDBflipsdecfalse on the first hybrid-36 letter and never recovers. After that,' 16'is all digits and spaces (isnumeric), so it misseshybrid36ToDecand falls through toint(resnum_str, 16).writePDB(..., hybrid36=True)then fails to round-trip: 16 → 22, 99 → 153, 100 → 256.All-digit residue fields are now parsed as decimal
int(resnum_str). Uppercase hybrid-36 still useshybrid36ToDec. Lowercase hex andhexadecimal=Truestay onint(..., 16).Fixes #2273