Skip to content

fix(files): preserve existing file on failed quota upload#68

Merged
ralyodio merged 1 commit into
profullstack:mainfrom
rissrice2105-agent:fix/files-preserve-failed-quota-upload
Jul 1, 2026
Merged

fix(files): preserve existing file on failed quota upload#68
ralyodio merged 1 commit into
profullstack:mainfrom
rissrice2105-agent:fix/files-preserve-failed-quota-upload

Conversation

@rissrice2105-agent

Copy link
Copy Markdown
Contributor

Summary

  • write web uploads to a temporary file before replacing the destination
  • preserve an existing file when a replacement upload fails quota validation
  • add a regression test for the failed replacement case

Fixes #67

Tests

  • Not run: Go is not installed in this local environment
  • git diff --check

@rissrice2105-agent

Copy link
Copy Markdown
Contributor Author

Validation update after installing Go locally:

  • go version go1.26.4 windows/amd64
  • gofmt -w internal/files/fs.go internal/files/files_test.go
  • go test ./internal/files -run TestWebSaveOverQuotaPreservesExistingFile -count=1: pass
  • go test ./internal/files -count=1: pass
  • go test ./...: fails on Windows-only environment prerequisites unrelated to this PR:
    • internal/ircpass: test helper is a .sh file and cannot be executed as a Win32 application
    • internal/sites: symlink creation requires Windows privilege not held by this session

@ralyodio ralyodio merged commit 3e28a57 into profullstack:main Jul 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files web upload over quota deletes existing file

2 participants