fix(feed-discovery): block additional reserved SSRF IP ranges#89
Closed
AmitabhainArunachala wants to merge 1 commit into
Closed
fix(feed-discovery): block additional reserved SSRF IP ranges#89AmitabhainArunachala wants to merge 1 commit into
AmitabhainArunachala wants to merge 1 commit into
Conversation
Closes profullstack#88 Expand feed-discovery SSRF guard to reject additional non-public IPv4 and IPv6 address ranges: IPv4: - Documentation TEST-NET-1/2/3 (192.0.2.0/24, 198.51.100.0/24, 203.0.113.0/24) - IETF protocol assignments (192.0.0.0/24) - Benchmark (198.18.0.0/15) - Multicast (224.0.0.0/4) and reserved (240.0.0.0/4) IPv6: - Discard-only (100::/64) - Benchmark (2001:2::/48) - Documentation (2001:db8::/32) - Full link-local scope (fe80::/10, not just fe80::) - Multicast (ff00::/8) Adds regression tests for all newly blocked ranges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88
Summary
Expands the feed-discovery SSRF guard to reject additional non-public/reserved IPv4 and IPv6 address ranges that were previously accepted as fetch targets.
IPv4 additions
IPv6 additions
Validation
Regression coverage
Added 2 new test cases covering all newly blocked ranges.