fix: always initialize _lock in Metric.__init__#1187
Closed
muhamedfazalps wants to merge 1 commit into
Closed
Conversation
When a metric has no labels (neither parent nor observable), _lock was never created, causing AttributeError when clear() or other methods access it. Fix: initialize self._lock unconditionally before the _is_parent() check. Fixes prometheus#1140.
Member
|
Thanks! This was actually already fixed in #1184 so I am closing it however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1140
When a metric has no labels (neither parent nor observable),
self._lockwas never created, causingAttributeErrorwhenclear()or other methods try to access it.Fix: Initialize
self._lock = Lock()unconditionally before the_is_parent()check.385 tests pass, 11 skipped.