fix(a11y/seo): downgrade FeedbackButton dialog titles from h1 to h2 - #50
fix(a11y/seo): downgrade FeedbackButton dialog titles from h1 to h2#50forgetso wants to merge 1 commit into
Conversation
The feedback modal is hidden by default but still lives in the DOM on every
docs page, so crawlers were seeing two extra h1 elements ("What's on your
mind?" and "Send us feedback") alongside the real page h1, tripping duplicate
H1 audit warnings across the entire site (including every localised copy).
Both dialog titles become h2s with a shared .dialog-title class; the scoped
selector is renamed to match, preserving the existing styling. Nested
.select-buttons h2 rules are unaffected.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for peaceful-pothos-9e62ce ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No updates since Nothing is lost — Converting to draft disables auto-merge, so PRs with auto-merge enabled are excluded from this entirely. |
|
No updates since Nothing is lost — Converting to draft disables auto-merge, so PRs with auto-merge enabled are excluded from this entirely. |
1 participant
Summary
<h1>elements (feedback.formTitleandfeedback.sendFeedback) alongside the real page<h1>.<h2 class="dialog-title">; the scopedh1 { … }selector is renamed to.dialog-title { … }so the styling is preserved without depending on the tag name..select-buttons h2rules are unaffected.Test plan
<h1>remains (the Starlight page title).🤖 Generated with Claude Code