Repository navigation
Add MWC live demo video to homepage modal - #25
Merged
Merged
Conversation
Swaps the placeholder div for a youtube-nocookie iframe. Video: HfAVCsJ0Tro
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Defer the iframe URL until the modal opens or use verified lazy loading.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds the MWC live demo YouTube embed to the homepage modal.
Changes:
- Replaces the placeholder with a privacy-enhanced YouTube iframe.
- Adds video metadata and playback permissions.
File summaries
| File | Summary |
|---|---|
index.html |
Embeds the MWC demo video; the hidden iframe may trigger an unintended third-party request before the modal opens. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
warshawcal
added a commit
that referenced
this pull request
Sep 12, 2026
The promo iframe loaded YouTube on every homepage visit, even for visitors who never opened the modal — a third-party request to Google before any user action. Switching to data-src defers the load until openModal() runs. Homepage now makes zero YouTube requests until the video is clicked. Uses the deferral path already in initModal (#25). Also removes two no-op allow tokens: accelerated-video-decode (not a real Permissions Policy token) and gyroscope (360° video only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the placeholder div for a youtube-nocookie iframe. Video: HfAVCsJ0Tro