Repository navigation
Tests: run cliploopcheck in CI, stretch a roomscheck export - #235
Merged
Merged
Conversation
With a 1 s delay, a slow software-GL run (one llvmpipe thread) finished the linked export before the West click, so the placeholder line never printed. The check passes with 5 s and still fails with 1 s there.
rixnobis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/cliploopcheck.pyhad no line inbuild.yml. The suite finds GUI checks through that file, so CI never ran it. It passes locally with 0 failures.roomscheckstretched one export by 1 s. A software-GL run with one llvmpipe thread finished it before the West click and failed. 5 s passes there.