mangaplus: label a dead chapter subscriber-only instead of dropping it - #508
Merged
Merged
Conversation
`availability.ts` already works out which listed chapters the viewer will not serve -- HEART GEAR 1001867 and its like, sitting in midChapterList behind the far-future sentinel, subscriber-only in everything but name. Having worked it out, `collect` then dropped them. That drop is indistinguishable, from the platform's side, from MangaPlus having deleted the chapter: both leave it absent from the listing, so the removal pass cards it "removed". A MANGA Plus MAX subscriber can open every one of them. They are now reported with `unavailableReason: "subscriber-only"` and `subscriptionName: "MANGA Plus MAX"`, so the card names the tier that unlocks the chapter and links to the publisher, rather than claiming the chapter is gone. What the viewer refuses is the logged-out request this extension makes, which is a fact about us, not about the chapter. `findDeadChapters` is untouched, including the budget, the trust gate and the per-slot cross-tab: what counts as dead has not changed, only what is done with the answer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with #142 and publoader-extensions-private#15/#16.
The gap
availability.tsalready works out which listed chapters the viewer will not serve — HEART GEAR 1001867 and its like, sitting inmidChapterListbehind the far-future sentinel, subscriber-only in everything but name. Its own header says so:Having worked that out,
collectthen dropped them. From the platform's side a dropped chapter is indistinguishable from one MangaPlus deleted, so the removal pass cards it"removed"— and a MANGA Plus MAX subscriber can open every one of them.The change
Dead chapters are now reported with
unavailableReason: "subscriber-only"andsubscriptionName: "MANGA Plus MAX", so the card names the tier that unlocks the chapter and links to the publisher, instead of claiming it is gone.What the viewer refuses is the logged-out request this extension makes. That is a fact about us, not about the chapter, and the card should say which.
findDeadChaptersis untouched — budget, trust gate, per-slot cross-tab and all. What counts as dead has not changed; only what is done with the answer.Testing
62 tests pass, both typecheck configs clean. 1.2.1 → 1.3.0.
Note
verify_pagesis currently off in production: it was enabled during the 2026-09-09 sweep and MangaPlus refused every request, so it was turned back off. This change only affects what happens when it is on.