fix(ci): Dockerイメージのビルドが失敗する問題の対処 - #1829
Merged
Merged
Conversation
Assisted-by: Claude Sonnet 5
Assisted-by: Claude Sonnet 5
Hadolint:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1829 +/- ##
=======================================
Coverage 45.08% 45.08%
=======================================
Files 167 167
Lines 5740 5740
Branches 847 847
=======================================
Hits 2588 2588
Misses 3152 3152 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MikuroXina
approved these changes
Sep 6, 2026
Contributor
|
とりあえずの対処としては ok ですが, 検証を無効化するのは依存関係の潜在的なエラーが実行時に先延ばしされるので危ないかもしれないです. ビルド時に lefthook を無効化できないか手元で試してみましたが, 環境変数の設定 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pnpm run prepareを実行するようにしていましたが、そのタイミングでlefthookが落ちる問題があってビルドが落ちてましたverifyDepsBeforeRunで postinstall が暗黙的に実行されるのが原因っぽく、verifyDepsBeforeRunオプションで実行を止めるようにしましたAdditional information