Skip to content

fix(ci): Dockerイメージのビルドが失敗する問題の対処 - #1829

Merged
MikuroXina merged 2 commits into
mainfrom
fix/docker-build-postinstall-rerun
Sep 6, 2026
Merged

fix(ci): Dockerイメージのビルドが失敗する問題の対処#1829
MikuroXina merged 2 commits into
mainfrom
fix/docker-build-postinstall-rerun

Conversation

@laminne

@laminne laminne commented Sep 6, 2026

Copy link
Copy Markdown
Member

What does this PR do?

  • prismaClientを生成するためにpnpm run prepareを実行するようにしていましたが、そのタイミングでlefthookが落ちる問題があってビルドが落ちてました
    • verifyDepsBeforeRunで postinstall が暗黙的に実行されるのが原因っぽく、 verifyDepsBeforeRunオプションで実行を止めるようにしました

Additional information

@laminne laminne self-assigned this Sep 6, 2026
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

Hadolint: success


@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.08%. Comparing base (9d9c46a) to head (f4dd96c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1829   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files         167      167           
  Lines        5740     5740           
  Branches      847      847           
=======================================
  Hits         2588     2588           
  Misses       3152     3152           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laminne
laminne requested a review from MikuroXina September 6, 2026 03:47
@laminne laminne added the T: development Development Environment Issues & PR label Sep 6, 2026
@MikuroXina

Copy link
Copy Markdown
Contributor

とりあえずの対処としては ok ですが, 検証を無効化するのは依存関係の潜在的なエラーが実行時に先延ばしされるので危ないかもしれないです. ビルド時に lefthook を無効化できないか手元で試してみましたが, 環境変数の設定 (CI=trueLEFTHOOK=0) は効果がなさそうなのでそちらをもっと検証する必要がありそうです.

@MikuroXina
MikuroXina added this pull request to the merge queue Sep 6, 2026
Merged via the queue into main with commit 9779528 Sep 6, 2026
7 checks passed
@MikuroXina
MikuroXina deleted the fix/docker-build-postinstall-rerun branch September 6, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T: development Development Environment Issues & PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants