feat(ci): build and ship aarch64-unknown-linux-gnu - #364
Open
avrabe wants to merge 2 commits into
Open
Conversation
v1.4.1 shipped four binaries — x86_64-linux, both macOS arches, Windows. ARM Linux had none: servers, arm64 containers, ARM CI runners and single board machines all had to build from source with a C++ toolchain, which is the dependency #313 exists to remove. The deferral note in release.yml gave the reason as "cross-compiling z3-sys for aarch64-linux is untested". That was true and is now moot: the target builds NATIVELY on a GitHub-hosted arm64 Linux runner, so nothing is cross-compiled. z3-sys vendors and statically compiles z3, so it needs no host libz3 on any runner, ARM included, and those runners are free for public repositories — which this one is. --- where the evidence lives is the load-bearing decision --- `release.yml` only fires on a tag push. A target added THERE ALONE would ship on the strength of a job that had never run: the unexercised-gate shape this repository keeps finding, and precisely what v1.4.1 was cut to punish. So the target is also built on EVERY PR via the CI matrix, and a toolchain or z3-sys regression on ARM fails a check immediately instead of surfacing during a release. --- both #311 gates extended, not left x86_64-only --- The glibc/libstdc++ floor is now asserted from the ARM binary's OWN symbols (the step no longer hardcodes the x86_64 path), and the binary is SMOKE-RUN natively on the ARM image it was built for rather than merely inspected. A shipped target whose floor is only hoped-for is exactly how v1.2.0 went out unloadable. The rivet artifact is deliberately `draft`, not `verified`: the workflow edit is not evidence. It flips when the ARM job has actually run green. Refs #311, #313 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RZof1M5HMBSYVZPeoT4MEn
`Build (ubuntu-22.04-arm)` ran green on PR #364. That settles the three things actually in doubt: arm64 Linux runners are available to this repository, z3-sys compiles its vendored C++ natively on ARM, and loom builds for the target. It settles nothing about the release path. Publishing the archive, asserting the glibc floor from the ARM binary's symbols, and smoke-running it all live in release.yml, which fires only on a tag push. That code is written and reviewed; none of it has executed. So the artifact stays `draft` with each criterion labelled PROVEN or PENDING A TAG. Flipping it to `verified` on the strength of the CI job would assert an untested gate — the exact defect class v1.4.1 was cut to remove, and it would be a poor way to celebrate that. Refs #311, #313 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RZof1M5HMBSYVZPeoT4MEn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.4.1 shipped four binaries — x86_64-linux, both macOS arches, Windows. ARM Linux had none: servers, arm64 containers, ARM CI runners and SBCs all had to build from source with a C++ toolchain, which is the dependency #313 exists to remove.
The stated blocker no longer applies
release.ymlcarried this note:True when written, and now moot. The target builds natively on a GitHub-hosted arm64 Linux runner — nothing is cross-compiled.
z3-sysvendors and statically compiles z3, so it needs no hostlibz3on any runner, ARM included, and those runners are free for public repositories, which this one is.Where the evidence lives is the load-bearing decision
release.ymlonly fires on a tag push. A target added there alone would ship on the strength of a job that had never run — the unexercised-gate shape this repo keeps finding, and precisely what v1.4.1 was cut to punish.So the target is also built on every PR via the CI matrix. A toolchain or
z3-sysregression on ARM now fails a check immediately, instead of surfacing during a release when it is most expensive.This PR's own CI is that evidence. If the
ubuntu-22.04-armbuild is not green here, the release entry does not belong on main.Both #311 gates extended, not left x86_64-only
A shipped target whose floor is only hoped-for is exactly how v1.2.0 went out unloadable.
Status is
draft, deliberatelyTEST-AARCH64-LINUX-RELEASE-TARGETis filed against v1.5.0 asdraft, notverified. The workflow edit is not evidence. It flips when the ARM job has actually run green — and the release gate correctly reads✗ NOT cuttableuntil then.Refs #311, #313