Preserve existing URL query parameters when params are provided - #1174
Draft
ferstar wants to merge 1 commit into
Draft
Preserve existing URL query parameters when params are provided#1174ferstar wants to merge 1 commit into
ferstar wants to merge 1 commit into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paramsare providedcopy_with(params=...)and the query manipulation helpers replacement semantics unchangedURL,Request, empty parameter inputs, same-name values, explicit queries, and invalid URL typesCloses #1173
Testing
uv run --frozen coverage run -m pytest -q— 1998 passed, 1 skippeduv run --frozen coverage report --fail-under=100— 100%uv run --frozen ruff format --check --diff src/httpx2 tests/httpx2 src/httpcore2 tests/httpcore2 benchmarkuv run --frozen ruff checkuv run --frozen mypy src/httpx2 tests/httpx2 src/httpcore2 tests/httpcore2 benchmarkuv run --frozen python scripts/unasync.py --checkChecklist