Skip to content

Mention header name in encoding errors - #1184

Open
Ryota-Di wants to merge 2 commits into
pydantic:mainfrom
Ryota-Di:issue-864
Open

Mention header name in encoding errors#1184
Ryota-Di wants to merge 2 commits into
pydantic:mainfrom
Ryota-Di:issue-864

Conversation

@Ryota-Di

@Ryota-Di Ryota-Di commented Sep 2, 2026

Copy link
Copy Markdown

Summary

  • Preserves the existing error behavior while including the header name in the error message.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Review in cubic

@codspeed-hq

codspeed-hq Bot commented Sep 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing Ryota-Di:issue-864 (63aaf35) with main (36d636a)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/httpx2/httpx2/_models.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant