Add an icon to every menu entry - #22
Merged
Merged
Conversation
Adds two sections to CLAUDE.md: - Publishing: which remote is the live site (upstream = pyoomph, origin = the fork), the branch -> push -> gh pr create -> merge flow, and why a PR from a fork always shows a failing check (deploy.yml also runs on pull_request, but GITHUB_TOKEN is read-only for fork PRs, so only the push to gh-pages 403s - nothing is published and it clears on merge). - Finding new publications for pubs.bib: the About page lists publications that *use* pyoomph, not everything that cites it. Records the three open citation indexes to query for works citing the main JCP paper, the dedupe traps, and the screening step. Papers that cite the JCP paper without using pyoomph are collected in the new pubs_excluded.md, so they do not have to be screened again. It starts with the four found on 2026-08-04. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XJeo2Rp5sDjApHWf77wza
The two external entries get their projects' marks: the Read the Docs book and the GitHub Invertocat, both in white. White is a permitted variant for both - Read the Docs publishes a "light logo" (#fafafa) for dark backgrounds, and GitHub's brand guidelines allow the Invertocat in white and explicitly permit using the mark to link to GitHub. The three internal entries get hand-drawn glyphs on the same 24x24 grid (star, info circle, download arrow), filled with currentColor so they follow the label colour on hover. The marks are inline SVG rather than image files, so nothing needs to be added under _generated/media/. `#menu a` becomes white-space: nowrap to keep each mark on the same line as its label when the menu wraps on narrow screens. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fmhceke9votYhvWyGSBKyG
cdiddens
added a commit
that referenced
this pull request
Aug 7, 2026
A PR from a fork only ever gets a read-only GITHUB_TOKEN, whatever the permissions: contents: write declaration says, so the push to gh-pages always failed with a 403 and marked the run red. Nothing was published by those runs, and nothing could have been - see the runs on PRs #19-#22. Gating the deploy step on the event turns the PR check into what is actually useful there: it verifies that gen_page.sh still builds, which would catch e.g. an upstream readthedocs layout change breaking gen_example_gallery.py. Publishing still happens on push to main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fmhceke9votYhvWyGSBKyG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small icon in front of each of the five nav entries.
#fafafa) for dark backgrounds, and GitHub's brand guidelines list white as one of the allowed colours and explicitly permit using the mark to link to GitHub.currentColorso they follow the label colour on hover.Both marks are inline SVG, so nothing new lands under
_generated/media/.#menu abecomeswhite-space: nowrapso each icon stays on the same line as its label when the menu wraps on narrow screens.Note: the deploy check will show red, as it does on every PR from a fork — the build succeeds and only the
gh-pagespush fails on the read-only token. It goes green on merge.🤖 Generated with Claude Code
https://claude.ai/code/session_01Fmhceke9votYhvWyGSBKyG