spawn/call: don't force param cmd to be mutable + allow more kwargs on msvc - #390
Open
Avasam wants to merge 1 commit into
Open
spawn/call: don't force param cmd to be mutable + allow more kwargs on msvc#390Avasam wants to merge 1 commit into
spawn/call: don't force param cmd to be mutable + allow more kwargs on msvc#390Avasam wants to merge 1 commit into
Conversation
Avasam
force-pushed
the
def-spawn-better-types
branch
from
December 20, 2025 06:19
1e73a19 to
22f61d9
Compare
Contributor
Author
|
Avasam
commented
Dec 20, 2025
Avasam
force-pushed
the
def-spawn-better-types
branch
2 times, most recently
from
July 4, 2026 19:08
ed891f5 to
fe21a7f
Compare
Avasam
force-pushed
the
def-spawn-better-types
branch
8 times, most recently
from
July 9, 2026 23:16
079d4ab to
c9b7218
Compare
spawn: don't force param cmd to be mutablespawn: don't force param cmd to be mutable + allow more kwargs on msvc
Avasam
force-pushed
the
def-spawn-better-types
branch
3 times, most recently
from
July 11, 2026 01:56
342d873 to
c0c5654
Compare
Avasam
force-pushed
the
def-spawn-better-types
branch
from
August 3, 2026 14:36
c0c5654 to
fe8e8c1
Compare
spawn: don't force param cmd to be mutable + allow more kwargs on msvcspawn/call: don't force param cmd to be mutable + allow more kwargs on msvc
Avasam
force-pushed
the
def-spawn-better-types
branch
from
August 3, 2026 14:51
fe8e8c1 to
6842a4c
Compare
Contributor
Author
|
Simplified a lot with 3f09fab |
Avasam
force-pushed
the
def-spawn-better-types
branch
2 times, most recently
from
August 3, 2026 15:06
d16129e to
c96f0be
Compare
Avasam
force-pushed
the
def-spawn-better-types
branch
from
August 11, 2026 16:53
c96f0be to
8553db5
Compare
Avasam
added a commit
to Avasam/typeshed
that referenced
this pull request
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has 2 advantages:
cmddoesn't have to be mutable. Sotuplesare usableMutableSequenceis invariant. which can cause issues with union types since you need to match the exact full union type (some checkers do allow partial union match for inline/literal sequences)[arg-type]I also improved the possible param types by using an overload on
search_path(sincesearch_pathallowsbytes | str | PathLike[str], but notPathLike[bytes])Open question: Since
verboseisn't used inspawn, maybe it's better to not even expose it as a possible kwargs inCompilerclasses ? (no runtime change, just hiding it from the type annotation in wrapper methods)Edit: Updated with 3f09fab