Treat a string path as a one-file group in newer_pairwise_group - #428
Open
gyanu2507 wants to merge 1 commit into
Open
Treat a string path as a one-file group in newer_pairwise_group#428gyanu2507 wants to merge 1 commit into
gyanu2507 wants to merge 1 commit into
Conversation
Passing newer_group through newer_pairwise iterated a str as characters, so a real source file was almost always reported as missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #411.
newer_pairwise_groupwaspartial(newer_pairwise, newer=newer_group).newer_pairwisepasses each source through as a single item, andnewer_groupiterates it. A string path is iterable, so it compared each character as a filename and almost always looked like the source was missing.A lone path is now wrapped as a one-file group. Existing list-of-groups calls are unchanged.