Skip to content

fix(deprecation): Fix deprecation in case of table reuse #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyrollo merged 1 commit into from
Aug 29, 2026
Merged

fix(deprecation): Fix deprecation in case of table reuse #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions display_api/deprecation.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,19 @@ local function deprecated_global_table(deprecated_global_name, replacement_globa
assert(type(replacement_global_name) == 'string', "replacement_global_name should be a string.")
assert(deprecated_global_name ~= '', "deprecated_global_name should not be empty.")
assert(replacement_global_name ~= '', "replacement_global_name should not be empty.")
assert(rawget(_G, deprecated_global_name) == nil, "deprecated global does not exist.")

if rawget(_G, deprecated_global_name) ~= nil then
minetest.log('warning', string.format(
'Deprecated global "%s" still exists, not deprecating it.', deprecated_global_name))
return
end

if _G[replacement_global_name] == nil then
minetest.log('warning', string.format(
'Replacement global "%s" does not exists.', replacement_global_name))
return
end

local meta = {
deprecated = deprecated_global_name,
replacement = replacement_global_name,
Expand All @@ -66,7 +73,6 @@ local function deprecated_global_table(deprecated_global_name, replacement_globa
setmetatable(_G[deprecated_global_name], meta)
end


-- deprecated(1) -- December 2018 - Deprecation of groups display_modpack_node and display_lib_node
-- Group to be removed from display API register_lbm
minetest.after(0, function()
Expand Down
9 changes: 8 additions & 1 deletion font_api/deprecation.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,19 @@ local function deprecated_global_table(deprecated_global_name, replacement_globa
assert(type(replacement_global_name) == 'string', "replacement_global_name should be a string.")
assert(deprecated_global_name ~= '', "deprecated_global_name should not be empty.")
assert(replacement_global_name ~= '', "replacement_global_name should not be empty.")
assert(rawget(_G, deprecated_global_name) == nil, "deprecated global does not exist.")

if rawget(_G, deprecated_global_name) ~= nil then
minetest.log('warning', string.format(
'Deprecated global "%s" still exists, not deprecating it.', deprecated_global_name))
return
end

if _G[replacement_global_name] == nil then
minetest.log('warning', string.format(
'Replacement global "%s" does not exists.', replacement_global_name))
return
end

local meta = {
deprecated = deprecated_global_name,
replacement = replacement_global_name,
Expand Down