Skip to content

Removed unnecessary _override_check_invalid_name_in_main patch - #1394

Merged
david-yz-liu merged 2 commits into
masterfrom
remove-old-patch
Sep 24, 2026
Merged

david-yz-liu merged 2 commits into
masterfrom
remove-old-patch

Conversation

@david-yz-liu

@david-yz-liu david-yz-liu commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This pull request removes the patch _override_check_invalid_name_in_main. We've replaced pylint's invalid-name check with our own InvalidNameChecker, which implements the "main block" exemption for variable name.

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 35803167003

Coverage increased (+0.002%) to 90.909%

Details

  • Coverage increased (+0.002%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 4081
Covered Lines: 3710
Line Coverage: 90.91%
Coverage Strength: 17.67 hits per line

💛 - Coveralls

@david-yz-liu
david-yz-liu merged commit 5302384 into master Sep 24, 2026
30 checks passed
@david-yz-liu
david-yz-liu deleted the remove-old-patch branch September 24, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants