fix(math): rotate_around_point offsets from the rotation center#2875
Open
Sanjays2402 wants to merge 1 commit into
Open
fix(math): rotate_around_point offsets from the rotation center#2875Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
rotate_around_point computed the rotated displacement vector correctly but added it to the target point instead of the source (the rotation center), so the result was displaced by the source-to-target vector. Rotating (5, 0) around (3, 0) by 90 degrees returned (5, 2) instead of (3, 2). Added a regression test covering the rotation as well as the full-turn and zero-radius early-return paths. Closes pythonarcade#2753
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2753
rotate_around_pointcomputed the rotated displacement vector correctly but added it to the target point instead of the source (the rotation center), so the result came out displaced by the source-to-target vector: rotating(5, 0)around(3, 0)by 90 degrees returned(5, 2)instead of(3, 2).Added a regression test in
tests/unit/test_math.py(fails ondevelopment, passes with the fix) that also covers the full-turn and zero-radius early returns.