fix(dynamo): remap engine output symbols during fake execution - #4627
Open
narendasan wants to merge 1 commit into
Open
fix(dynamo): remap engine output symbols during fake execution#4627narendasan wants to merge 1 commit into
narendasan wants to merge 1 commit into
Conversation
Remap serialized compile-time shape expressions into the active runtime ShapeEnv instead of reusing symbol names across namespaces. Fresh data-dependent output symbols retain size-like constraints, and composite input expressions are solved against runtime dimensions. Fixes #4618 Fixes #4619 Fixes #4622 Tests: - pytest tests/py/dynamo/models/test_meta_kernel_shape_inference.py -n0 (10 passed) - original issue reproductions for #4618, #4619, and #4622
github-actions
Bot
added
component: tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues
Closes #4618
Closes #4619
Closes #4622
Tests
Stack
1 of 7. Base: main. Follow-up: narendasan/fix-engine-scalar-io.