fix(dynamo): preserve explicit device placement across partitions - #4629
Open
narendasan wants to merge 1 commit into
Open
fix(dynamo): preserve explicit device placement across partitions#4629narendasan wants to merge 1 commit into
narendasan wants to merge 1 commit into
Conversation
Keep torch-executed submodules on their source devices unless compilation explicitly offloaded the module, and reject _to_copy conversions that move between devices because TensorRT can represent the dtype cast but not the placement change. Fixes #4613 Fixes #4615 Tests: - pytest tests/py/dynamo/conversion/test_casts.py -n0 (8 passed) - pytest tests/py/dynamo/models/test_device_placement.py -n0 (2 passed) - original issue reproductions for #4613 and #4615
github-actions
Bot
added
component: tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues
Closes #4613
Closes #4615
Tests
Stack
3 of 7. Base: #4628. Follow-up: narendasan/fix-truncate-double-metadata.