Skip to content

fix: Dynamo compile support for None outputs - #4640

Open
dongwoonhyun wants to merge 2 commits into
pytorch:mainfrom
dongwoonhyun:dhyun/dynamo_compile_None_outputs
Open

fix: Dynamo compile support for None outputs#4640
dongwoonhyun wants to merge 2 commits into
pytorch:mainfrom
dongwoonhyun:dhyun/dynamo_compile_None_outputs

Conversation

@dongwoonhyun

Copy link
Copy Markdown

Description

Currently, any model outputs that are None literals (e.g., auxiliary outputs) cause a compile crash when trying to access the attribute target.

This PR adds a continue if is None, and adds a simple test.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

If any of the output node's args are a None literal in the traced graph, output.target leads to an AttributeError. Add an is None check to skip.
@meta-cla meta-cla Bot added the cla signed label Aug 28, 2026
@github-actions github-actions Bot added component: tests Issues re: Tests component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant