Skip TRTInterpreter.validate_conversion when partition already proved full support. - #4693
Open
micwill755 wants to merge 1 commit into
Open
Skip TRTInterpreter.validate_conversion when partition already proved full support.#4693micwill755 wants to merge 1 commit into
micwill755 wants to merge 1 commit into
Conversation
… full support. compile_module already walks CONVERTERS via get_graph_converter_support. Under require_full_compilation with a complete count, the extra get() pass in interpreter __init__ cannot find missing ops, so skip it.
micwill755
requested review from
cehongwang and
narendasan
and removed request for
zewenli98
September 8, 2026 22:38
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRTInterpreter.validate_conversion()whencompile_modulealready proved full converter coverage (require_full_compilationandnum_supported_ops == total_ops).__init__walk is a secondCONVERTERS.get()over everycall_function/call_method/call_modulenode. Partition already did the same lookup viaget_graph_converter_support. Under full compilation a missing-op warning cannot fire, so the extra pass is redundant.interpret_module_to_result/ engine-converter / test-harness construction still validates (defaultskip_conversion_validation=False). Construct stillCONVERTERS.gets per node when it converts.interpreter.validate_conversion0.102s → 0s.PR 9 of the compile-startup stack; based on #4599.
Type of change
Test plan
torchtrt-213rc10): skip-offvalidate_conversion0.102s; skip-on the hook does not run. Engine still builds; steady ~0.43s.__init__skipsvalidate_conversionwhen the flag is set, and still warns when it is notChecklist
Stack created with GitHub Stacks CLI • Give Feedback 💬