Disable sam_fast custom flash without Triton block pointers - #2701
Open
warrendeng wants to merge 1 commit into
Open
Disable sam_fast custom flash without Triton block pointers#2701warrendeng wants to merge 1 commit into
warrendeng wants to merge 1 commit into
Conversation
warrendeng
had a problem deploying
to
docker-s3-upload
August 19, 2026 19:59 — with
GitHub Actions
Error
warrendeng
had a problem deploying
to
docker-s3-upload
August 19, 2026 19:59 — with
GitHub Actions
Error
warrendeng
had a problem deploying
to
docker-s3-upload
August 19, 2026 19:59 — with
GitHub Actions
Error
warrendeng
force-pushed
the
warrendeng/sam-fast-disable-flash-without-blockptr
branch
from
August 19, 2026 20:00
64f5141 to
0bdae05
Compare
warrendeng
had a problem deploying
to
docker-s3-upload
August 19, 2026 20:00 — with
GitHub Actions
Failure
warrendeng
requested a deployment
to
docker-s3-upload
August 19, 2026 20:00 — with
GitHub Actions
Queued
warrendeng
had a problem deploying
to
docker-s3-upload
August 19, 2026 20:00 — with
GitHub Actions
Failure
warrendeng
marked this pull request as ready for review
August 19, 2026 20:38
Contributor
Author
|
Both CI failures exist on main:
|
atalman
approved these changes
Aug 19, 2026
|
@warrendeng has imported this pull request. If you are a Meta employee, you can view this in D116691248. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional
segment-anything-fastflash_4kernel still uses Triton's legacytl.make_block_ptrandtl.advanceAPIs, which were removed by triton-lang/triton#10833. This causes the fullsam_fastTorchBench model to fail during eager validation with newer Triton revisions.Detect those APIs before importing
segment_anything_fastand disable the kernel withSEGMENT_ANYTHING_FAST_USE_FLASH_4=0when they are unavailable. On Triton 3.9+, the benchmark continues exercising the full model through its existing SDPA fallback, while older Triton behavior remains unchanged.Test plan:
python3.12 -m py_compile torchbenchmark/models/sam_fast/__init__.pytl.advanceand verified the adapter disables the custom kernel before package import