Arm backend: Legalize unsigned RESCALE from wide inputs - #21393
Merged
bdemirb merged 2 commits intoJul 27, 2026
Conversation
TOSA RESCALE only allows output_unsigned when the input is int8 or int16. Some preserved uint8 IO paths can produce a final wide accumulator RESCALE with output_unsigned set, which newer model-converter builds reject. Canonicalize that case during TOSA serialization by emitting a signed RESCALE to the target integer dtype first, followed by a legal signed-input to unsigned-output boundary RESCALE. Change-Id: Ia980ad42ecae62bf921fee6a64e2f1e7824f2632 Signed-off-by: Baris Demir <baris.demir@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21393
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a49664c with merge base fa4508e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label "partner: arm" |
Collaborator
Author
|
@pytorchbot label "release notes: arm" |
pytorch-bot
Bot
added
partner: arm
robell
approved these changes
Jul 27, 2026
robell
left a comment
robell
left a comment
Collaborator
There was a problem hiding this comment.
Approved - has had internal code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TOSA RESCALE only allows output_unsigned when the input is int8 or int16. Some preserved uint8 IO paths can produce a final wide accumulator RESCALE with output_unsigned set, which newer model-converter builds reject.
Canonicalize that case during TOSA serialization by emitting a signed RESCALE to the target integer dtype first, followed by a legal signed-input to unsigned-output boundary RESCALE.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani