Conversation
Signed-off-by: Zhibo Lin <147509942+LE0-Lin@users.noreply.github.com>
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughLocal datetime range filtering now retains nanosecond precision when comparing timestamps with range boundaries. Parameterized tests check Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Local datetime range filters now distinguish timestamps that differ below one microsecond. Timestamps with six or fewer fractional digits are handled correctly. No outstanding merge-blocking issue remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Local datetime filters currently truncate payload fractions to microseconds:
...000000001Zincorrectly satisfieslte=...000000Zand fails the correspondinggt. Preserve the sub-microsecond remainder in range comparisons so local results agree with unindexed server filtering, while keeping the existing datetime parser and ordering behavior.Fixes #1526
Validation:
python -m pytest qdrant_client/local/tests -q: 176 passed.pre-commit run --files qdrant_client/local/payload_filters.py qdrant_client/local/tests/test_datetimes.py: passed.git diff --check: passed.All Submissions:
devbranch. Did you create your branch fromdev?Changes to Core Features:
Codex assisted with diagnosis, implementation, and test execution. The reported results are from the assisted environment (Python 3.12.0, Windows); this disclosure does not assert independent manual review or execution by the human contributor. The full remote/fastembed suite was not run.