Skip to content

fix: accept point sequences in upsert - #1528

Open
fallintoplace wants to merge 1 commit into
qdrant:devfrom
fallintoplace:fix/upsert-point-sequences
Open

fallintoplace wants to merge 1 commit into
qdrant:devfrom
fallintoplace:fix/upsert-point-sequences

Conversation

@fallintoplace

Copy link
Copy Markdown

What

  • Accept tuples and other point sequences in upsert.

Why

  • Points accepts Sequence, but tuples of models.PointStruct fail in local, REST and gRPC modes.

Implementation

  • Use sequence checks in the existing handlers.
  • Regenerate the async client and add regression coverage.

@fallintoplace
fallintoplace requested a review from joein as a code owner October 4, 2026 15:31
@netlify

netlify Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit d791e95
🔍 Latest deploy log https://app.netlify.com/projects/poetic-froyo-8baba7/deploys/6ac27146caa91a00086c3767
😎 Deploy Preview https://deploy-preview-1528--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dd5b2a06-4344-41e3-a7f8-bc6e7f71baa1
📥 Commits

Reviewing files that changed from the base of the PR and between d64b76d and d791e95.

📒 Files selected for processing (4)
  • qdrant_client/async_qdrant_remote.py
  • qdrant_client/local/local_collection.py
  • qdrant_client/qdrant_remote.py
  • tests/test_upsert_sequences.py

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Local and remote upsert paths now accept supported Sequence inputs, excluding strings and byte sequences. Local handling converts accepted sequences to lists. Remote REST and gRPC paths convert sequences into their existing request formats. Tests cover list, tuple, and UserList inputs, empty sequences, invalid dimensions, text and byte inputs, and remote request contents.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d791e

Upsert now accepts tuples and other point sequences in local, REST and gRPC modes, with tests covering them. No merge-blocking risk was identified.

Security Architecture Review

Security architecture risk: 🔵 Low · up to d791e

The compatibility expansion preserves existing request routing, conversion, and local validation-before-write behavior. No introduced security vulnerability was identified. Confidence is bounded because arbitrary custom sequences and production persistence recovery were not fully assessed.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — Effective exposure remains point writes to collections reachable through the caller's existing local instance or configured remote client. The widening changes accepted input containers, not target selection or client authority; no additional tenant, service, or environment reachability is supported by the reviewed change.

Trust Boundaries and Controls

  • observed — Caller-supplied sequences are normalized before local mutation or remote request dispatch. Local complete-request validation remains in place, and remote sequences use the same conversion and transport boundaries as lists. Server-side authorization and validation were not independently assessed.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: accepting point sequences in upsert.
Description check ✅ Passed The description explains the change, its motivation, and the regression coverage. It relates directly to the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant