fix: accept point sequences in upsert - #1528
fallintoplace wants to merge 1 commit into
Conversation
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughLocal and remote upsert paths now accept supported Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Upsert now accepts tuples and other point sequences in local, REST and gRPC modes, with tests covering them. No merge-blocking risk was identified. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The compatibility expansion preserves existing request routing, conversion, and local validation-before-write behavior. No introduced security vulnerability was identified. Confidence is bounded because arbitrary custom sequences and production persistence recovery were not fully assessed. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
upsert.Why
PointsacceptsSequence, but tuples ofmodels.PointStructfail in local, REST and gRPC modes.Implementation