Repository navigation
feat: store host passwords in system keychain - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Move host passwords out of the SQLite database (plaintext) into the macOS Keychain, so credentials are no longer stored in cleartext on disk.
Changes
src-tauri/src/main.rs)ServerDeck, keyed by host id); DB keeps only a__serverdeck_keychain__marker.resolve_host_passwordresolves credentials from keychain at connect time (with legacy plaintext fallback).duplicate_hostcommand copies the keychain-stored password to the duplicated host.src/lib/api.ts,src/App.tsx,src/lib/i18n.ts)SavedHost.hasPasswordflag; passwords are never sent to the UI.Validation
tsc --noEmit✅ /cargo check✅sshpass+sshlogin succeeds with the keychain-stored password on multiple hosts.Notes
mainis at 0.0.35 —Cargo.toml/Cargo.lockmay need a merge withmainbefore merging to avoid downgrading the version.