Conversation
tzarc
approved these changes
Jun 20, 2026
tzarc
left a comment
tzarc
left a comment
Member
There was a problem hiding this comment.
Dunno if these are anactual issue, but inconsistent compared to previous state.
| git_cmd = ' '.join([s.replace(' ', r'\ ') for s in git_clone]) | ||
|
|
||
| cli.log.error("Could not run '%s': %s: %s", git_cmd, e.__class__.__name__, e) | ||
| cli.log.error(f'Could not run "{git_cmd}": {e.__class__}: {e}') |
Member
There was a problem hiding this comment.
Suggested change
| cli.log.error(f'Could not run "{git_cmd}": {e.__class__}: {e}') | |
| cli.log.error(f'Could not run "{git_cmd}": {e.__class__.__name__}: {e}') |
| print(f'Warning: {qmk_firmware} does not end in "qmk_firmware". Do you need to set QMK_HOME to "{qmk_firmware}/qmk_firmware"?') | ||
|
|
||
| print('Error: %s: %s', (e.__class__.__name__, e)) | ||
| print(f'Error: {e.__class__}: {e}') |
Member
There was a problem hiding this comment.
Suggested change
| print(f'Error: {e.__class__}: {e}') | |
| print(f'Error: {e.__class__.__name__}: {e}') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the code base uses a mixture of f-strings and modulo Operator.
This can cause issues when user supplied config contains a
%, and produces errors when expanding the strings.