You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR will be closed due to a policy change (Task 6131).
Reason: The method for freezing inventory valuation (Separate Valuation Mode + automatic transfer of remaining GRNI)
is no longer necessary for the time being, and we have decided to proceed first with the rate limit order method for #147purchase_deposit_currency. With the limit order method, the invoice amount itself is adjusted to match the actual payment amount,
eliminating the need to suppress the price difference SVL.
In case the requirement resurfaces, the branch 16.0-add-purchase_deposit_separate_valuation will
be retained (it can also be restored from refs/pull/148/head).
Handover Notes for Resumption:
Suppressing _apply_price_difference and the automatic transfer of the remaining GRNI via _sync_sep_val_grni_adjustment
are a set of actions. If you only implement the suppression, the GRNI will not close.
Adjustment journal entries are only generated once the PO is marked as “fully invoiced,” and are regenerated via delete + create with each status change. If the entries have been cleared, they cannot be deleted and will result in a UserError.
On staging (axlstest12), Separate Valuation Mode was enabled for 86 POs, and
15 adjustment journal entries (all posted but not cleared) had been generated.
The merge line for this PR has also been removed from /odoo/code/repos.yml (staging).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6131