[7186][IMP] purchase_order_no_owner: skip the owner check during test runs - #155
Open
AungKoKoLin1997 wants to merge 1 commit into
Open
[7186][IMP] purchase_order_no_owner: skip the owner check during test runs#155AungKoKoLin1997 wants to merge 1 commit into
AungKoKoLin1997 wants to merge 1 commit into
Conversation
The check raised on every button_confirm() call, so tests of other modules that confirm a purchase order failed as soon as this module was installed. Skip it while test_enable is set, unless the caller opts in with the test_purchase_order_no_owner context key, and cover both paths with tests.
AungKoKoLin1997
requested review from
kanda999,
nobuQuartile,
smorita7749 and
yostashiro
August 25, 2026 07:20
AungKoKoLin1997
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner check in
button_confirm()raised on every call, so any test of anothermodule that confirms a purchase order failed as soon as this module was installed.
The check is now skipped while
test_enableis set, unless the caller opts in withthe
test_purchase_order_no_ownercontext key - the same pattern core uses forforce_report_renderinginir_actions_report. Production behaviour is unchanged:form, list view, API and scheduled calls are all still checked.
Tests added for confirm-without-owner (raises), confirm with
owner_id, confirm withno_owner, the skip when the context key is absent, and theno_owneronchange.QT7186