Skip to content

QCLINUX: arm64: dts: qcom: Enable SDE DSI on RB3Gen2 - #1672

Open
arpit-dev-geek wants to merge 2 commits into
qualcomm-linux:tech/overlay/dtfrom
arpit-dev-geek:dsi_overlay
Open

QCLINUX: arm64: dts: qcom: Enable SDE DSI on RB3Gen2#1672
arpit-dev-geek wants to merge 2 commits into
qualcomm-linux:tech/overlay/dtfrom
arpit-dev-geek:dsi_overlay

Conversation

@arpit-dev-geek

Copy link
Copy Markdown

Add SDE DSI nodes for Kodiak and enable the RB3Gen2 overlay
path through the LT9611 bridge.

Depends on #1492.
Please review only the top commit:
da3c917 QCLINUX: arm64: dts: qcom: enable SDE DSI on rb3gen2

Yash Gupta and others added 2 commits July 9, 2026 23:36
Add SDE (Snapdragon Display Engine) overlay dts for RB3gen2
(QCS6490/Kodiak) board including MDSS, MDP, DSI, eDP nodes
and enables its compilation in the Makefile.

Signed-off-by: Yash Gupta <yash.gupta@oss.qualcomm.com>
Add SDE DSI nodes for Kodiak and enable the RB3Gen2 overlay
path through the LT9611 bridge.

Signed-off-by: Arpit Saini <arpisain@qti.qualcomm.com>
@qcomlnxci
qcomlnxci requested review from a team, jingyiwang42, Dmitry Baryshkov (lumag) and yijiyang and removed request for a team August 11, 2026 11:08
@qlijarvis

Copy link
Copy Markdown

PR #1672 — validate-patch

PR: #1672

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 2/2 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1672 - Add rb3gen2 SDE overlay dts and enable SDE DSI
Upstream commit: N/A (vendor-only QCLINUX: commits)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commits
Body preserves rationale Clear description of SDE overlay additions
Fixes tag present/correct N/A No fixes tag required for new feature
Authorship preserved Commit 1: Yash Gupta; Commit 2: Arpit Saini
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds qcs6490-rb3gen2-sde overlay build rules
arch/arm64/boot/dts/qcom/kodiak-sde.dtsi New file: SDE/MDSS/DSI/eDP nodes for Kodiak
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-sde.dtso New overlay: enables SDE on RB3Gen2 with LT9611 bridge

Issues

  • Integration presence: Both commits are missing from qcom-next and topics branches. This is expected for new vendor-specific work but should be tracked for integration.

Verdict

Vendor-only commits with correct QCLINUX: prefix. No upstream validation required. Commits are well-formed and appropriately scoped for vendor tree. Missing from qcom-next/topics is expected for new work pending integration.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 2/2 commit(s) are missing from both qcom-next and topics (expected for new vendor work)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/2 [PATCH 2/2] QCLINUX: arm64: dts: qcom: enable SDE DSI on rb3gen2 missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/2
partial_commits: 0/2
missing_commits: 2/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Fail - 2/2 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1672 — checker-log-analyzer

PR: #1672
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31485262430

Checker Result Summary
Checker Result Summary
checkpatch 10 errors, 25 warnings, 1 check across 2 commits
dt-binding-check ⏭️ No binding changes
dtb-check Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance 2 commits missing required prefix
tag-check 2 commits use QCLINUX: prefix (not valid for tech/overlay/dt branch)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1672 - Add rb3gen2 SDE overlay dts
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31485262430
Target branch: tech/overlay/dt

Checker Result Summary
checkpatch 10 errors, 25 warnings, 1 check across 2 commits
dt-binding-check ⏭️ No binding changes
dtb-check Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance 2 commits missing required prefix
tag-check 2 commits use QCLINUX: prefix (not valid for tech/overlay/dt branch)

❌ checkpatch

Root cause: Multiple coding style violations including trailing whitespace, spaces instead of tabs, undocumented DT compatible strings, and lines exceeding 100 columns.

Failure details:

Commit 1be046d ("QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts"):

WARNING: DT compatible string "qcom,smmu_sde_unsec" appears un-documented
  #52: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:16

WARNING: DT compatible string "qcom,edp-pll-7nm" appears un-documented
  #63: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:27

WARNING: DT compatible string "qcom,sde-kms" appears un-documented
  #71: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:35

WARNING: DT compatible string "qcom,msm-hdcp" appears un-documented
  #301: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:265

WARNING: DT compatible string "qcom,edp-display" appears un-documented
  #308: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:272

WARNING: line length of 107 exceeds 100 columns (×2)
  #223, #226: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:187, 190

ERROR: trailing whitespace
  #356: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:320

ERROR: code indent should use tabs where possible (×9)
WARNING: please, no spaces at the start of a line (×13)
  #356, #440-472: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:320, 404-436

CHECK: Please don't use multiple blank lines
  #68: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:32

total: 10 errors, 22 warnings, 1 checks, 504 lines checked

Commit da3c917 ("QCLINUX: arm64: dts: qcom: enable SDE DSI on rb3gen2"):

WARNING: DT compatible string "qcom,dsi-ctrl-hw-v2.5" appears un-documented
  #24: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:269

WARNING: DT compatible string "qcom,dsi-phy-v4.1" appears un-documented
  #64: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:309

WARNING: DT compatible string "qcom,dsi-display" appears un-documented
  #114: FILE: arch/arm64/boot/dts/qcom/kodiak-sde.dtsi:485

total: 0 errors, 3 warnings, 0 checks, 207 lines checked

Fix:

  1. Trailing whitespace and indentation errors (commit 1):

    # Remove trailing whitespace
    sed -i 's/[[:space:]]*$//' arch/arm64/boot/dts/qcom/kodiak-sde.dtsi
    
    # Fix spaces to tabs (lines 320, 404-436)
    # Manually review and convert leading spaces to tabs in these sections
  2. Long lines (commit 1):
    Wrap lines 187 and 190 in kodiak-sde.dtsi to stay within 100 columns.

  3. Multiple blank lines (commit 1):
    Remove extra blank line at line 32 in kodiak-sde.dtsi.

  4. Undocumented DT compatible strings (both commits):
    These are vendor-specific Qualcomm display driver compatible strings. Options:

    • Add binding documentation in Documentation/devicetree/bindings/display/msm/ (preferred for upstream)
    • Accept as vendor-specific for internal tree (checkpatch will still warn)

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 7a0df21b1d7d..8c023ecb8174

❌ check-patch-compliance

Root cause: Both commits use QCLINUX: prefix, which is not in the allowed list for check-patch-compliance.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: enable SDE DSI on rb3gen2
Commit summary does not start with a required prefix

Fix:

The check-patch-compliance checker only accepts these prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:.

Since these are vendor-specific DTS overlay additions with no upstream equivalent, you have two options:

  1. If posted to a mailing list: Change prefix to FROMLIST: and add Link: trailer pointing to the lore.kernel.org URL.

  2. If vendor-only (not posted upstream): The QCLINUX: prefix is correct for vendor-only changes, but check-patch-compliance will always fail. This is a known limitation of the checker for vendor-internal commits.

Note: For the tech/overlay/dt branch, vendor-only overlay DTS files are common and QCLINUX: is the appropriate prefix. The checker failure is expected for this type of change.


❌ tag-check

Root cause: Both commits use QCLINUX: prefix, but the target branch tech/overlay/dt is not qcom-next or qcom-next-staging, so all commits must have a valid subject prefix.

Failure details:

The target branch is tech/overlay/dt. According to the tag-check rules, all branches except qcom-next and qcom-next-staging require every commit to start with one of these prefixes:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Analysis:

Both commits do have the QCLINUX: prefix:

  • Commit 1be046d: QCLINUX: arm64: dts: qcom: Add rb3gen2 SDE overlay dts
  • Commit da3c917: QCLINUX: arm64: dts: qcom: enable SDE DSI on rb3gen2

Verdict:PASS — Both commits have valid subject prefixes (QCLINUX:).

The check-patch-compliance failure is a separate issue (that checker has a more restrictive prefix list and doesn't accept QCLINUX:).


Verdict

3 blockers to fix before merge:

  1. checkpatch (CRITICAL): Fix 10 errors (trailing whitespace, tabs vs spaces) in commit 1. The 25 undocumented DT compatible string warnings are acceptable for vendor-specific display driver nodes.

  2. check-patch-compliance (EXPECTED): The QCLINUX: prefix is correct for vendor-only overlay DTS files. This checker failure is a known limitation and can be accepted for tech/overlay/dt branch.

  3. tag-check: ✅ PASS — Commits have valid QCLINUX: prefix.

Recommended action:

  • Fix the 10 checkpatch errors (whitespace and indentation) in commit 1.
  • The 25 warnings about undocumented DT compatible strings can be accepted as vendor-specific.
  • The check-patch-compliance failure is expected for QCLINUX: prefixed commits and can be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants