Revert "watchdog: fixing incorrect watchdog address and details" - #926
Revert "watchdog: fixing incorrect watchdog address and details"#926apateriy-qcom wants to merge 1 commit into
Conversation
fc0e0db to
2642da1
Compare
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
2642da1 to
63db300
Compare
This reverts commit c07f7f7. 0x17821000 is APSS_WDT_NSEC_WWDOG (windowed watchdog), not the register layout the qcom,kpss-wdt driver expects. That layout lives at 0x17826000 (APSS_WDT_SW_NSEC_APSS_WDT), matching reg_offset_data_kpss. With the wrong address, driver writes hit the wrong registers, so the counter never advanced and no bite ever occurred despite valid-looking MMIO reads. Restores GIC_ESPI 848 to match the block at 0x17826000. Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
63db300 to
8234cd9
Compare
Shiraz Hashim (shashim-quic)
left a comment
Shiraz Hashim (shashim-quic)
left a comment
There was a problem hiding this comment.
on the other hand, let's not overdo the commit log. Do not mention things like ip catalogue etc. which is internal.
Just mention what was wrong and your revert corrects it.
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
1 similar comment
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
2 participants
This reverts commit c07f7f7.
Watchdog WWDOG address was incorrect.
Changing it correct WDT address fixes kernel panic going to download mode path.
The reverted commit pointed the qcom,kpss-wdt node at WWDOG address.
The corrected address was pointed to NSEC_APSS_WDT address.