fix: repair cross-package test and type failures - #119
Open
stooit wants to merge 1 commit into
Open
Conversation
- api.ts: import renamed hook useDebounce (was stale useThrottle), re-export as useSearchDebounce so @e2e/utils consumer + api tests pass - Button: apply aria-label to <button> with iconOnly fallback + dev warn (WCAG 4.1.2); guard process.env for browser bundles - date.ts: format with en-GB numeric day / 2-digit month so 1 Mar 2024 renders 1/03/2024 (was 01/03/2024) - DataTable: use functional setState updater to remove latent stale closure in sort toggle - tsconfig: add bun-types to compilerOptions.types to resolve bun:test 13/13 tests pass, tsc --noEmit clean. No test files or deps changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repairs all 5 failing tests and all type errors across the monorepo. Bugs spanned three packages and one build-config file. 13/13 tests pass and
tsc --noEmitis clean.Changes
apps/web/src/lib/api.ts— The utility hook was renamed but the old name lingered.useThrottleno longer exists in@e2e/utils(the real, genuinely-debounce export isuseDebounce). Fixed the import touseDebounceand re-export it asuseSearchDebounce(the public alias the api test asserts). FixesTS2305+ bothapi moduletests.packages/ui/src/components/Button/Button.tsx—ariaLabelwas destructured but never applied to the rendered<button>. Now applied asaria-label={ariaLabel ?? (iconOnly ? "Button" : undefined)}— the fallback is scoped toiconOnlyso labelled icon buttons get their real name, unlabelled ones stay non-null (WCAG 4.1.2), and text buttons keep their content-derived accessible name. Added a dev-onlyconsole.warn(guarded withtypeof process !== "undefined"so it can't throw in a browser bundle) when an icon-only button ships without a label.packages/utils/src/format/date.ts—formatDateproduced01/03/2024(leading-zero day). Switched toen-GBwith{ day: "numeric", month: "2-digit", year: "numeric" }so 1 Mar 2024 →1/03/2024, keeping a 4-digit year.formatDateTimeleft unchanged.packages/ui/src/components/DataTable/DataTable.tsx— Converted the sort toggle to a functionalsetSortDir(prev => ...)updater, removing a latent stale-closure bug. No existing test caught it (React re-renders between clicks), but the closure form breaks under batched clicks / concurrent rendering. Sort semantics unchanged.tsconfig.json— Added"types": ["bun-types"]sobun:testresolves in the 4 test files (was 4xTS2307).Verification
bun run test-> 13 pass / 0 fail./node_modules/.bin/tsc --noEmit-> clean, exit 0Constraints honoured
Assumptions / follow-ups (non-blocking)
en-AUforce-pads the day in this ICU build and can't satisfy the no-leading-zero assertion, soen-GBwas used;formatDatenow differs in locale fromformatDateTime."Button"aria-label fallback clears the automated check but isn't a useful name; the dev warning surfaces the real defect. A type-level requirement would be a stronger fix but would touch beyond scope.🤖 Generated with QuantCode