fix: repair cross-package bugs so all tests and typecheck pass

apps/web/src/lib/api.ts

@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }

packages/ui/src/components/Button/Button.tsx

@@ -17,13 +17,9 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Icon-only buttons render no visible text, so they must be given an
+ * `aria-label` describing the action (WCAG 2.2 SC 4.1.2). A development-time
+ * warning fires when one is omitted.
  */
 export function Button({
   children,
@@ -34,13 +30,26 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  // Prefer an explicit aria-label; fall back to string children when the label
+  // was omitted. Icon-only buttons render no text, so they must always end up
+  // with a non-empty accessible name (WCAG 2.2 SC 4.1.2).
+  const rawLabel = ariaLabel ?? (typeof children === "string" ? children : undefined)
+  const derivedLabel = rawLabel?.trim() ? rawLabel : undefined
+  const accessibleName = iconOnly ? derivedLabel || "Button" : ariaLabel
+
+  if (process.env.NODE_ENV !== "production" && iconOnly && !derivedLabel) {
+    console.warn(
+      "Button: `iconOnly` buttons require an `aria-label` describing the action " +
+        '(WCAG 2.2 SC 4.1.2). Falling back to "Button", which is not a meaningful name.',
+    )
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleName}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}

packages/utils/src/format/date.ts

@@ -1,21 +1,21 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * formatDate returns Australian-style D/MM/YYYY — day not zero-padded, month
+ * zero-padded, 4-digit year.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
+  // en-AU resolves numeric day/month to its dd/MM/y skeleton, which forces a
+  // leading zero onto the day (01/03/2024). Ordering is already correct, so
+  // rebuild from parts and un-pad the day only — giving 1/03/2024.
   return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
-  }).format(date)
+  })
+    .formatToParts(date)
+    .map((part) => (part.type === "day" ? String(Number(part.value)) : part.value))
+    .join("")
 }
 
 export function formatDateTime(date: Date): string {

tsconfig.json

@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]