fix: repair all failing tests across utility library - #291
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero instead of returning Infinity - string-utils: fix wordCount for consecutive whitespace; implement truncate - task-manager: implement remove, update, and sortBy - date-utils: fix off-by-one in formatRelative day rounding - validator: widen isEmail for long/multi-level TLDs; fix isUrl port handling All 60 tests pass. No test files or dependencies modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across 5 source files. 60 pass / 0 fail,
tsc --noEmitclean. No test files or dependencies modified.Changes
dividenow throws on division by zero (was returningInfinity).wordCountcollapses consecutive whitespace (splits on/\s+/after trim);truncateimplemented (reserves 3 chars for ellipsis, cuts at word boundary, output always<= maxLength).remove(returns delete boolean),update(partial updates,falsefor unknown id), andsortBy(priority high→medium→low, status ordering,createdAtoldest-first). Copies before in-place sort solist()order is preserved.formatRelativenow roundsabs(diffHours)/24, fixing the off-by-one at the 36-hour boundary (36h → "2 days ago").isEmailregex widened for multi-level subdomains and TLDs longer than 4 chars (and now correctly rejects empty labels likeuser@example..com), with a 254-char cap;isUrlno longer rejects URLs with an explicit port (http://localhost:3000).Verification
bun test→ 60 pass / 0 fail (70 expect() calls, 5 files)tsc --noEmitclean., linear scaling, plus the 254-char cap).Assumptions / notes
divide(x, 0)now throws instead of returningInfinity— required by the test spec.truncatewithmaxLength <= 3hard-slices without an ellipsis (not pinned by any test).truncatecan split a UTF-16 surrogate pair when the cut lands mid-pair;updatecan't clear the optionaldescriptionfield via{ description: undefined }. Can follow up if desired.