Repository navigation
Fix PHP 8.4 compatibility: Add void return type to resetBuilderState method - #344
Merged
Merged
Conversation
armanist
self-requested a review
October 27, 2025 08:03
armanist
approved these changes
Oct 27, 2025
Collaborator
|
Great observation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHP 8.4 compatibility: Add missing void return type to resetBuilderState()
Problem:
Running
composer create-project quantum/project projectthrows a fatal error:PHP Fatal error: Declaration of Quantum\Libraries\Database\Adapters\Sleekdb\SleekDbal::resetBuilderState() must be compatible with Quantum\Libraries\Database\Adapters\Sleekdb\Statements\Result::resetBuilderState(): void
Solution:
Added missing
: voidreturn type to theresetBuilderState()method inSleekDbalclass to match the abstract method signature in theResulttrait.Files Changed:
src/Libraries/Database/Adapters/Sleekdb/SleekDbal.php(line 373)