Skip to content

400 make http client testable by allowing curl and multi curl injection and removing external api dependency from tests #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armanist merged 3 commits into from
Jan 13, 2026
Merged

400 make http client testable by allowing curl and multi curl injection and removing external api dependency from tests #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c23f114
Make `HttpClient` testable by allowing `Curl` and `MultiCurl` injecti…
armanist Jan 13, 2026
b9d334a
Merge branch 'refs/heads/master' into 400-Make-HttpClient-testable-by…
armanist Jan 13, 2026
7769c31
cs:fix
armanist Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/Libraries/HttpClient/HttpClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,22 +86,24 @@ class HttpClient
/**
* Creates request
* @param string $url
* @param Curl|null $client
* @return HttpClient
*/
public function createRequest(string $url): HttpClient
public function createRequest(string $url, ?Curl $client = null): HttpClient
{
$this->client = new Curl();
$this->client = $client ?: new Curl();
$this->client->setUrl($url);
return $this;
}

/**
* Creates multi request
* @param MultiCurl|null $client
* @return HttpClient
*/
public function createMultiRequest(): HttpClient
public function createMultiRequest(?MultiCurl $client = null): HttpClient
{
$this->client = new MultiCurl();
$this->client = $client ?: new MultiCurl();

$this->client->complete(function (Curl $instance) {
$this->handleResponse($instance);
Expand All @@ -114,11 +116,12 @@ public function createMultiRequest(): HttpClient
* Creates async multi request
* @param callable $success
* @param callable $error
* @param MultiCurl|null $client
* @return HttpClient
*/
public function createAsyncMultiRequest(callable $success, callable $error): HttpClient
public function createAsyncMultiRequest(callable $success, callable $error, ?MultiCurl $client = null): HttpClient
{
$this->client = new MultiCurl();
$this->client = $client ?: new MultiCurl();

$this->client->success($success);
$this->client->error($error);
Expand Down
Loading