Skip to content

Fix Translator to merge shared and module translations - #403

Merged
armanist merged 1 commit into
quantum-php:masterfrom
armanist:402-Fix-Translator-to-merge-shared-and-module-translations-(module-overrides-shared)
Jan 13, 2026
Merged

armanist merged 1 commit into
quantum-php:masterfrom
armanist:402-Fix-Translator-to-merge-shared-and-module-translations-(module-overrides-shared)

Conversation

@armanist

Copy link
Copy Markdown
Collaborator

Fixes #402

@armanist armanist added this to the 3.0.0 milestone Jan 13, 2026
@armanist armanist added bug Something isn't working enhancement New feature or request labels Jan 13, 2026
@codecov

codecov Bot commented Jan 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.67%. Comparing base (697d4fc) to head (425bd07).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Libraries/Lang/Translator.php 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #403   +/-   ##
=========================================
  Coverage     80.66%   80.67%           
- Complexity     2470     2472    +2     
=========================================
  Files           229      229           
  Lines          6543     6546    +3     
=========================================
+ Hits           5278     5281    +3     
  Misses         1265     1265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@armanist
armanist merged commit c2efe7a into quantum-php:master Jan 13, 2026
6 checks passed
@armanist
armanist deleted the 402-Fix-Translator-to-merge-shared-and-module-translations-(module-overrides-shared) branch October 23, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Translator to merge shared and module translations (module overrides shared)

2 participants