Skip to content

Update ob_implicit_flush for PHP 8+ and ensure string type for search… - #428

Merged
armanist merged 1 commit into
quantum-php:masterfrom
armanist:master
Mar 16, 2026
Merged

armanist merged 1 commit into
quantum-php:masterfrom
armanist:master

Conversation

@armanist

@armanist armanist commented Mar 16, 2026 •

Copy link
Copy Markdown
Collaborator

… query

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Improved search parameter handling in controllers with explicit type casting.
    • Enhanced compatibility with PHP 8.0 and later versions.

@coderabbitai

coderabbitai Bot commented Mar 16, 2026 •

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Three files receive targeted updates: the Mailer trait now conditionally sets output buffering behavior based on PHP version (false for PHP 8.0+, 0 otherwise), while two controller templates add explicit string type casting to search parameters for stricter type handling.

Changes

Cohort / File(s) Summary
Mailer Output Buffering
src/Mailer/Traits/MailerTrait.php
Modified ob_implicit_flush() parameter from constant 0 to PHP-version-aware expression PHP_VERSION_ID >= 80000 ? false : 0, preserving behavior across PHP 7 and PHP 8+ environments.
Search Parameter Type Casting
src/Module/Templates/DemoApi/src/Controllers/PostController.php.tpl, src/Module/Templates/DemoWeb/src/Controllers/PostController.php.tpl
Added explicit (string) type cast to search parameter extraction, ensuring strict string type for downstream operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A whisker of PHP, a cast so fine,
Buffers and searches align with time,
Version-aware and types declared clear,
Little tweaks make code sincere! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the two main changes: updating ob_implicit_flush for PHP 8+ and ensuring string type casting for search parameters across multiple controller files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Mar 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.63%. Comparing base (aea827b) to head (69e6375).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Mailer/Traits/MailerTrait.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #428   +/-   ##
=========================================
  Coverage     82.63%   82.63%           
- Complexity     2718     2719    +1     
=========================================
  Files           241      241           
  Lines          7300     7300           
=========================================
  Hits           6032     6032           
  Misses         1268     1268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@armanist
armanist merged commit 8aa62ea into quantum-php:master Mar 16, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant