Issue/474 stop cleanup

src/App/Enums/ExitCode.php

@@ -2,13 +2,34 @@
 
 declare(strict_types=1);
 
+/**
+ * Quantum PHP Framework
+ *
+ * An open source software development framework for PHP
+ *
+ * @package Quantum
+ * @author Arman Ag. <arman.ag@softberg.org>
+ * @copyright Copyright (c) 2018 Softberg LLC (https://softberg.org)
+ * @link http://quantum.softberg.org/
+ * @since 3.0.0
+ */
+
 namespace Quantum\App\Enums;
 
+/**
+ * Class ExitCode
+ * @package Quantum\App
+ * @codeCoverageIgnore
+ */
 final class ExitCode
 {
     public const SUCCESS = 0;
 
     public const FAILURE = 1;
 
     public const INVALID = 2;
+
+    private function __construct()
+    {
+    }
 }

src/App/Helpers/app.php

@@ -11,19 +11,3 @@
  * @link http://quantum.softberg.org/
  * @since 3.0.0
  */
-
-use Quantum\App\Exceptions\StopExecutionException;
-
-/**
- * Stops the app execution
- * @return never
- * @throws StopExecutionException
- */
-function stop(?Closure $closure = null, ?int $code = 0): void
-{
-    if ($closure instanceof Closure) {
-        $closure();
-    }
-
-    throw StopExecutionException::executionTerminated($code);
-}

tests/Unit/Http/Helpers/HttpHelperTest.php

@@ -2,7 +2,6 @@
 
 namespace Quantum\Tests\Unit\Http\Helpers;
 
-use Quantum\App\Exceptions\StopExecutionException;
 use Quantum\Session\Factories\SessionFactory;
 use Quantum\Tests\Unit\AppTestCase;
 use Quantum\Router\RouteCollection;
@@ -104,11 +103,9 @@ public function testRedirecting(): void
     {
         $this->assertFalse($this->response->hasHeader('Location'));
 
-        try {
-            redirect('/home');
-        } catch (StopExecutionException $e) {
+        $redirectResponse = redirect('/home');
 
-        }
+        $this->assertSame($this->response, $redirectResponse);
 
         $this->assertTrue($this->response->hasHeader('Location'));
 
@@ -121,11 +118,9 @@ public function testRedirectWithOldData(): void
 
         $this->request->create('POST', '/', ['firstname' => 'Josh', 'lastname' => 'Doe']);
 
-        try {
-            redirectWith('/signup', $this->request->all());
-        } catch (StopExecutionException $e) {
+        $redirectResponse = redirectWith('/signup', $this->request->all());
 
-        }
+        $this->assertSame($this->response, $redirectResponse);
 
         $this->assertTrue($this->response->hasHeader('Location'));