Issue/601 Adopt the PHP 8.1 syntax Rector proposes and remove its skips

rector.php

@@ -4,9 +4,6 @@
 
 use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
 use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
-use Rector\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector;
-use Rector\Php81\Rector\Array_\ArrayToFirstClassCallableRector;
-use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;
 use Rector\Set\ValueObject\LevelSetList;
 use Rector\Set\ValueObject\SetList;
 use Rector\Config\RectorConfig;
@@ -24,7 +21,4 @@
     ])
     ->withSkip([
         ClassPropertyAssignToConstructorPromotionRector::class,
-        ReadOnlyPropertyRector::class,
-        FunctionFirstClassCallableRector::class,
-        ArrayToFirstClassCallableRector::class,
     ]);

src/App/App.php

@@ -25,7 +25,7 @@ class App
 {
     private static ?AppContext $context = null;
 
-    private AppInterface $adapter;
+    private readonly AppInterface $adapter;
 
     public function __construct(AppInterface $adapter)
     {

src/App/AppContext.php

@@ -25,11 +25,11 @@
  */
 class AppContext
 {
-    private string $baseDir;
+    private readonly string $baseDir;
 
-    private DiContainer $container;
+    private readonly DiContainer $container;
 
-    private string $type;
+    private readonly string $type;
 
     private bool $stopped = false;
 

src/App/Pipeline.php

@@ -29,12 +29,12 @@ final class Pipeline
     /**
      * @var array<StageInterface<TContext>>
      */
-    private array $stages;
+    private readonly array $stages;
 
     /**
      * @var StageInterface<TContext>|null
      */
-    private ?StageInterface $closingStage;
+    private readonly ?StageInterface $closingStage;
 
     /**
      * @param array<StageInterface<TContext>> $stages

src/Archive/Adapters/PharAdapter.php

@@ -25,7 +25,7 @@
  */
 class PharAdapter implements ArchiveInterface
 {
-    private FileSystem $fs;
+    private readonly FileSystem $fs;
 
     private ?string $archiveName = null;
 

src/Archive/Adapters/ZipAdapter.php

@@ -25,7 +25,7 @@
  */
 class ZipAdapter implements ArchiveInterface
 {
-    private FileSystem $fs;
+    private readonly FileSystem $fs;
 
     private ?string $archiveName = null;
 

src/Archive/Archive.php

@@ -30,7 +30,7 @@
  */
 class Archive
 {
-    private ArchiveInterface $adapter;
+    private readonly ArchiveInterface $adapter;
 
     public function __construct(ArchiveInterface $adapter)
     {

src/Asset/Asset.php

@@ -29,18 +29,18 @@ class Asset
      */
     public const JS = 2;
 
-    private int $type;
+    private readonly int $type;
 
-    private string $path;
+    private readonly string $path;
 
-    private ?string $name;
+    private readonly ?string $name;
 
     /**
      * @var array<string>|null
      */
-    private ?array $attributes;
+    private readonly ?array $attributes;
 
-    private int $position;
+    private readonly int $position;
 
     /**
      * Asset templates

src/Auth/Auth.php

@@ -24,7 +24,7 @@
  */
 class Auth
 {
-    private AuthenticatableInterface $adapter;
+    private readonly AuthenticatableInterface $adapter;
 
     public function __construct(AuthenticatableInterface $adapter)
     {

src/Cache/Cache.php

@@ -28,7 +28,7 @@
  */
 class Cache
 {
-    private CacheInterface $adapter;
+    private readonly CacheInterface $adapter;
 
     /**
      * Cache constructor

src/Captcha/Captcha.php

@@ -26,7 +26,7 @@
  */
 class Captcha
 {
-    private CaptchaInterface $adapter;
+    private readonly CaptchaInterface $adapter;
 
     public function __construct(CaptchaInterface $adapter)
     {

src/Cron/CronLock.php

@@ -22,18 +22,18 @@
  */
 class CronLock
 {
-    private string $lockDirectory;
+    private readonly string $lockDirectory;
 
-    private string $taskName;
+    private readonly string $taskName;
 
-    private string $lockFile;
+    private readonly string $lockFile;
 
     /** @var resource|null */
     private $lockHandle;
 
     private bool $ownsLock = false;
 
-    private int $maxLockAge;
+    private readonly int $maxLockAge;
 
     private const DEFAULT_MAX_LOCK_AGE = 86400;
 

src/Cron/CronTask.php

@@ -29,7 +29,7 @@ class CronTask implements CronTaskInterface
     /**
      * Task name
      */
-    private string $name;
+    private readonly string $name;
 
     /**
      * Task callback

src/Cron/Schedule.php

@@ -22,7 +22,7 @@ class Schedule
     /**
      * Task name
      */
-    private string $name;
+    private readonly string $name;
 
     /**
      * Cron expression

src/Csrf/Csrf.php

@@ -35,9 +35,9 @@ class Csrf
      */
     public const TOKEN_KEY = 'csrf-token';
 
-    private Session $storage;
+    private readonly Session $storage;
 
-    private Hasher $hasher;
+    private readonly Hasher $hasher;
 
     /**
      * @throws ConfigException

src/Database/Schemas/Column.php

@@ -113,7 +113,7 @@ class Column
      */
     public const ATTR_ZEROFILL = 'UNSIGNED ZEROFILL';
 
-    private string $name;
+    private readonly string $name;
 
     private ?string $newName = null;
 

src/Debugger/Debugger.php

@@ -65,12 +65,12 @@ class Debugger
     /**
      * Store
      */
-    private DebuggerStore $store;
+    private readonly DebuggerStore $store;
 
     /**
      * DebugBar instance
      */
-    private DebugBar $debugBar;
+    private readonly DebugBar $debugBar;
 
     /**
      * Assets url

src/Di/DiContainer.php

@@ -28,7 +28,7 @@
  */
 class DiContainer
 {
-    private DiRegistry $registry;
+    private readonly DiRegistry $registry;
 
     /**
      * @var array<string, object>

src/Encryption/Adapters/SymmetricEncryptionAdapter.php

@@ -27,7 +27,7 @@ class SymmetricEncryptionAdapter implements EncryptionInterface
      */
     public const CIPHER_METHOD = 'aes-256-cbc';
 
-    private string $appKey;
+    private readonly string $appKey;
 
     /**
      * @throws BaseException|ReflectionException

src/Encryption/Cryptor.php

@@ -23,7 +23,7 @@
  */
 class Cryptor
 {
-    private EncryptionInterface $adapter;
+    private readonly EncryptionInterface $adapter;
 
     public function __construct(EncryptionInterface $adapter)
     {

src/Http/Traits/Request/Body.php

@@ -50,7 +50,7 @@ public function get(string $key, ?string $default = null, bool $raw = false)
         }
 
         return is_array($value)
-            ? array_map('strip_tags', $value)
+            ? array_map(strip_tags(...), $value)
             : strip_tags($value);
     }
 

src/Jwt/JwtToken.php

@@ -25,7 +25,7 @@ class JwtToken extends JWT
     /**
      * JWT secret key
      */
-    private string $key;
+    private readonly string $key;
 
     /**
      * Encryption algorithm

src/Lang/Lang.php

@@ -22,7 +22,7 @@ class Lang
 {
     private ?string $currentLang = null;
 
-    private LangAdapterInterface $adapter;
+    private readonly LangAdapterInterface $adapter;
 
     public function __construct(string $lang, LangAdapterInterface $adapter)
     {

src/Logger/Adapters/MessageAdapter.php

@@ -28,7 +28,7 @@ class MessageAdapter implements ReportableInterface
     /**
      * The number of last messages kept; 0 keeps every message
      */
-    private int $limit;
+    private readonly int $limit;
 
     public function __construct(int $limit = 1000)
     {

src/Logger/Logger.php

@@ -21,7 +21,7 @@
  */
 class Logger implements LoggerInterface
 {
-    private ReportableInterface $adapter;
+    private readonly ReportableInterface $adapter;
 
     public function __construct(ReportableInterface $adapter)
     {

src/Mailer/MailTrap.php

@@ -27,16 +27,16 @@
  */
 class MailTrap
 {
-    private FileSystem $fs;
+    private readonly FileSystem $fs;
 
-    private MessageParser $parser;
+    private readonly MessageParser $parser;
 
     /**
      * @var MessagePart|MessagePartInterface
      */
     private $message;
 
-    private string $emailsDirectory;
+    private readonly string $emailsDirectory;
 
     /**
      * @throws BaseException
@@ -126,7 +126,7 @@ public function getParsedDate(): ?string
     public function getParsedToAddresses(): array
     {
         $addresses = explode(',', $this->message->getHeaderValue('to'));
-        return array_map('trim', $addresses);
+        return array_map(trim(...), $addresses);
     }
 
     /**
@@ -144,7 +144,7 @@ public function getParsedFromAddress(): ?string
     public function getParsedCcAddresses(): array
     {
         $addresses = explode(',', $this->message->getHeaderValue('cc'));
-        return array_map('trim', $addresses);
+        return array_map(trim(...), $addresses);
     }
 
     /**
@@ -154,7 +154,7 @@ public function getParsedCcAddresses(): array
     public function getParsedBccAddresses(): array
     {
         $addresses = explode(',', $this->message->getHeaderValue('bcc'));
-        return array_map('trim', $addresses);
+        return array_map(trim(...), $addresses);
     }
 
     /**
@@ -164,7 +164,7 @@ public function getParsedBccAddresses(): array
     public function getParsedReplyToAddresses(): array
     {
         $addresses = explode(',', $this->message->getHeaderValue('reply-to'));
-        return array_map('trim', $addresses);
+        return array_map(trim(...), $addresses);
     }
 
     /**

src/Mailer/Mailer.php

@@ -32,7 +32,7 @@
  */
 class Mailer
 {
-    private MailerInterface $adapter;
+    private readonly MailerInterface $adapter;
 
     public function __construct(MailerInterface $adapter)
     {

src/Middleware/MiddlewareManager.php

@@ -34,11 +34,11 @@ class MiddlewareManager
     /**
      * Current module
      */
-    private ?string $module;
+    private readonly ?string $module;
 
-    private Route $route;
+    private readonly Route $route;
 
-    private bool $hasRateLimit;
+    private readonly bool $hasRateLimit;
 
     public function __construct(MatchedRoute $matchedRoute)
     {

src/Migration/MigrationManager.php

@@ -55,13 +55,13 @@ class MigrationManager
      */
     private array $migrations = [];
 
-    private TableFactory $tableFactory;
+    private readonly TableFactory $tableFactory;
 
-    private string $migrationFolder;
+    private readonly string $migrationFolder;
 
-    private FileSystem $fs;
+    private readonly FileSystem $fs;
 
-    private Database $db;
+    private readonly Database $db;
 
     /**
      * @throws BaseException|ConfigException|DiException|FileSystemException|ReflectionException

src/Module/ModuleLoader.php

@@ -41,7 +41,7 @@ class ModuleLoader
     /** @var array<string, Closure> */
     private array $moduleRouteClosures = [];
 
-    private FileSystem $fs;
+    private readonly FileSystem $fs;
 
     /**
      * @throws ModuleException|ConfigException|DiException|BaseException|ReflectionException