Repository navigation
Issue/606 Make install:openapi create the folders it needs - #608
Merged
armanist merged 1 commit intoOct 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #606. Part of #595. The changelog entry is written in a final pull request, after the sub-issues.
What changed
install:openapicreatesmodules/<Name>/resourcesbeforeresources/openapiwhen the module has noresourcesfolder, for example one generated from theDefaultApitemplate.copyResources()creates thepublic/assets/OpenApiUifolder before copying the Swagger UI files into it.testGenerateOpenapiSpecificationCreatesSpecFileused an@OAdocblock fixture and only checked thatspec.jsonwas not empty, so it passed with an empty specification now thatdoctrine/annotationsis gone. Its fixture is an attribute and it checks the title.Why
Both folders were assumed to exist. Without them the command failed with
mkdir(): No such file or directoryandcopy(...): Failed to open stream.LocalFileSystemAdapter::makeDirectory()is not made recursive, because other callers depend on it.Breaking changes
Testing
testCopyResourcesCreatesTheTargetFolderWhenItIsMissingandtestExecCreatesTheResourcesFoldersOfAModuleWithoutThem(runs the whole command on a module withoutresources). Both fail without the fix.testGenerateOpenapiSpecificationCreatesSpecFilenow asserts the specification title.