Repository navigation
Issue/541 Use back() in the shipped module templates - #624
Merged
armanist merged 3 commits intoOct 27, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
artem-dev2
approved these changes
Oct 27, 2026
andrey-smaelov
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #541.
What changed
DemoWebandToolkittemplates redirect back withback()instead of the manual referrer fallback:redirect(get_referrer() ?? base_url())becomesback()inDemoWebCommentController(twice) and theResetmiddleware, and inToolkitDatabaseControllerand theCreateTablemiddleware.redirectWith(get_referrer() ?? base_url(), $data)becomesback($data)in theDemoWebCommentandEditormiddlewares.Changedentry toCHANGELOG.md.Why
#540 added
back()and theback()helper, so generated code no longer needs to repeat the referrer fallback. The generated code also gets the same-origin check ofback().Breaking changes
None. Generated redirects behave as before for a same-origin referrer, and fall back to
base_url()for an external one. Modules generated earlier keep their code.Testing
New
tests/Unit/Module/Templates/RedirectTemplatesTest.php, for theDemoWebandToolkittemplates:get_referrer() ?? base_url()return back(Both checks fail on the templates before this change.
Notes for reviewers
redirect(base_url(true) . '/' . current_lang() . '/signin')and theredirectWith(...)ones), whichback()cannot express, and theGuestmiddleware. Its fallback isbase_url(true) . '/' . current_lang(), notbase_url(), soback()would change its behavior.