Skip to content

Merge 3.1.x into master - #629

Merged
armanist merged 2 commits into
masterfrom
3.1.x
Oct 27, 2026
Merged

armanist merged 2 commits into
masterfrom
3.1.x

Conversation

@armanist

@armanist armanist commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #627.

What changed

Merges the maintenance branch 3.1.x into master. It carries one change:

Why

3.1.x is the maintenance branch of the 3.1 line, and its changes are merged up into master so master keeps every fix. The CI triggers were merged into 3.1.x first, and master still has the old branches: ["master"] filter.

Breaking changes

None.

Notes for reviewers

Summary by CodeRabbit

  • Chores
    • Automated workflow runs now trigger on pushes to master and matching *.x branches.
    • Pull requests from any branch can now trigger the workflow, rather than being limited to those targeting master.

armanist and others added 2 commits October 27, 2026 17:12
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Issue/627 Run the CI workflow for the maintenance branches
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cc9ab7f4-3c4d-485a-b314-a79dc01e8277
Commits

Reviewing files that changed from the base of the PR and between 29d9b20 and ca35939.

Files selected for processing: 1
  • .github/workflows/php.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The PHP workflow now runs on pushes to master and branches matching *.x. Pull requests are no longer limited to a specified branch.

Changes: CI workflow triggers

Layer / File(s) Summary
Configure workflow branch triggers
.github/workflows/php.yml
Push triggers include branches matching *.x. Pull-request triggers no longer have a branch filter.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other · Severity of issue fixed: Medium

Suggested reviewers: hatik92

Merge Risk: Minimal · up to ca359

The workflow trigger update matches the stated CI coverage requirements and is ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: merging the 3.1.x maintenance branch into master.
Linked Issues check Passed Issue #627 requires pushes to master and *.x, plus unrestricted pull-request triggers. .github/workflows/php.yml now declares push.branches: ["master", "*.x"] and an unfiltered pull_request:…
Out of Scope Changes check Passed The whole change is limited to the trigger declarations in .github/workflows/php.yml. The two branch-trigger edits directly implement issue #627. The existing workflow jobs and configuration remain …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Full details: Linked Issues check

Explanation

Issue #627 requires pushes to master and *.x, plus unrestricted pull-request triggers. .github/workflows/php.yml now declares push.branches: ["master", "*.x"] and an unfiltered pull_request: trigger. The focused diff shows no changes to the job, matrix, services, or steps. The resulting file is valid YAML and covers future maintenance branches such as 3.2.x.

Full details: Out of Scope Changes check

Explanation

The whole change is limited to the trigger declarations in .github/workflows/php.yml. The two branch-trigger edits directly implement issue #627. The existing workflow jobs and configuration remain unchanged.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@armanist
armanist merged commit 328c7f6 into master Oct 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run the CI workflow for the maintenance branches

1 participant