Repository navigation
Issue/203 framework 3.1 catch up - #204
Merged
armanist merged 5 commits intoOct 18, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203
Summary
Framework 3.1 removes the Hook and Loader packages and no longer loads several files that this project still ships. This PR removes those leftovers and fixes a fresh-install bug: API routes behind the rate limiter returned 500 because the
cache/folder they write to did not exist.Changes
Fix: missing
cache/foldercache/.gitkeepand ignore the folder's contents (/cache/*).cache/datawithout creating parent folders, so the first API request on a fresh install failed withmkdir(): No such file or directory.Remove files the framework no longer reads
hooks/andshared/config/hooks.php(Hook was replaced by Event).shared/config/dependencies.php(onlymodules/<Module>/config/dependencies.phpis read).libraries/(no longer loaded).tests/_root, and thehooksandlibrariespaths inphpstan.neon.distandrector.php.CI
.travis.yml(PHP 7.3 and 7.4, unused).Apimodule, startphp qt serveand expectGET /api/poststo return 200. The feature tests createge, so nothing else covered thispath.Mailer
resendblock andRESEND_APIKEY, so the existing Resend adapter can be configured. Selecting it without a block threw aTypeError.Compatibility
No application code changes: configuration, ignore rules, CI and removed files only. Existing projects can delete the removed files, since nothing reads them.
Testing
composer cs:check,composer phpstan,composer rector:checkandcomposer testpass.