Skip to content

Issue/203 framework 3.1 catch up - #204

Merged
armanist merged 5 commits into
quantum-php:masterfrom
armanist:issue/203-framework-3-1-catch-up
Oct 18, 2026
Merged

armanist merged 5 commits into
quantum-php:masterfrom
armanist:issue/203-framework-3-1-catch-up

Conversation

@armanist

Copy link
Copy Markdown
Contributor

Closes #203

Summary

Framework 3.1 removes the Hook and Loader packages and no longer loads several files that this project still ships. This PR removes those leftovers and fixes a fresh-install bug: API routes behind the rate limiter returned 500 because the cache/ folder they write to did not exist.

Changes

Fix: missing cache/ folder

  • Add cache/.gitkeep and ignore the folder's contents (/cache/*).
  • The rate limiter creates cache/data without creating parent folders, so the first API request on a fresh install failed with mkdir(): No such file or directory.

Remove files the framework no longer reads

  • hooks/ and shared/config/hooks.php (Hook was replaced by Event).
  • shared/config/dependencies.php (only modules/<Module>/config/dependencies.php is read).
  • libraries/ (no longer loaded).
  • Their copies under tests/_root, and the hooks and libraries paths in phpstan.neon.dist and rector.php.

CI

  • Remove .travis.yml (PHP 7.3 and 7.4, unused).
  • Add an API smoke test: generate the Api module, start php qt serve and expect GET /api/posts to return 200. The feature tests createge, so nothing else covered thispath.

Mailer

  • Add the resend block and RESEND_APIKEY, so the existing Resend adapter can be configured. Selecting it without a block threw a TypeError.

Compatibility

No application code changes: configuration, ignore rules, CI and removed files only. Existing projects can delete the removed files, since nothing reads them.

Testing

  • composer cs:check, composer phpstan, composer rector:check and composer test pass.
  • To verify the fix on a fresh checkout:
    php qt core:env && php qt core:key
    php qt module:generate Api --templ
    php qt serve
    curl -i http://127.0.0.1:8000/api/posts   # 200 (was 500)
  • CI runs on PHP 8.0, 8.1 and 8.2.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-18T21:29:35.111541Z ed0f236 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@armanist armanist changed the title Issue/203 framework 3 1 catch up Issue/203 framework 3.1 catch up Oct 18, 2026
@armanist
armanist merged commit 3d8da7d into quantum-php:master Oct 18, 2026
4 checks passed
@armanist
armanist deleted the issue/203-framework-3-1-catch-up branch October 18, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align the project with framework 3.1 and fix the fresh-install API 500

1 participant