Skip to content

Run rector:check in CI after PHPStan - #206

Merged
armanist merged 1 commit into
quantum-php:masterfrom
armanist:ci/rector-check
Oct 19, 2026
Merged

armanist merged 1 commit into
quantum-php:masterfrom
armanist:ci/rector-check

Conversation

@armanist

@armanist armanist commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • Added a Run Rector step (composer rector:check) to .github/workflows/php.yml, right after Run PHPStan.
  • Added a Changed entry to the 3.1.0 changelog.

Why

The project defines composer rector:check and a rector.php, but CI never ran it, so the Rector configuration was not enforced. The framework runs the same step in its workflow since quantum-php/framework#587.

Breaking changes

None. Workflow and changelog only.

Testing

composer rector:check reports no changes on master, so the new step passes. CI runs it on PHP 8.0, 8.1 and 8.2.

Summary by CodeRabbit

  • Chores
    • The continuous integration workflow now runs an additional automated code-quality check after its existing analysis step. This expands the validation performed during development and is reflected in the project changelog. No changes to product features or behavior are included in this update.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-19T14:12:57.996789Z 5783768 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e6ea2248-4e85-4c9b-adff-b5ec6a70afff
📥 Commits

Reviewing files that changed from the base of the PR and between 608a508 and 5783768.

📒 Files selected for processing: 2
  • .github/workflows/php.yml
  • CHANGELOG.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The PHP workflow now runs composer rector:check after PHPStan. The 3.1.0 changelog records this CI step.

Changes: Rector CI Check

Layer / File(s) Summary
Add and record the Rector check
.github/workflows/php.yml, CHANGELOG.md
The workflow runs composer rector:check after PHPStan. The 3.1.0 changelog records the check.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 57837

The Rector check is wired into the PHP workflow as documented, with no identified compatibility issue that needs resolution before merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: running rector:check in CI after PHPStan.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@armanist
armanist merged commit 6db87d9 into quantum-php:master Oct 19, 2026
5 checks passed
@armanist
armanist deleted the ci/rector-check branch October 19, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant