Add keyboard shortcuts help overlay (press ?) - #15
Merged
Merged
Conversation
|
@Munan059 is attempting to deploy a commit to the naman's projects Team on Vercel. A member of the Team first needs to authorize it. |
nmndwivedi
approved these changes
Sep 19, 2026
nmndwivedi
left a comment
nmndwivedi
left a comment
Collaborator
There was a problem hiding this comment.
Tested in the React demo on top of current main: ? toggles the overlay, Esc / ? / backdrop / close button all dismiss it, it follows light and dark themes, and it's torn down in destroy(). Two small nits I'll tidy in a follow-up rather than block on: the new line in _keyDown is over-indented, and 'help' should be added to the EditorEvent union in the types. Thanks!
nmndwivedi
added a commit
that referenced
this pull request
Sep 19, 2026
Follow-up to #15: add 'help' to EditorEvent, fix the indentation of the new _keyDown branch, list ? in the README key table, and cover the overlay's open/close/destroy paths. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing
?toggles a dismissable overlay listing the keyboard map from the README, styled to the current theme.What changed
editor.js:_keyDownemits ahelpevent on?(Shift+/).ui.js: adds the overlay, built inside the UI layer (.qd-ui) and toggled viaeditor.on('help', ...). Closes onEsc/?/ backdrop click / close button, and is torn down indestroy().quickdraw.css: theme-styled.qd-help-*rules reusing the existing--qd-*tokens.The overlay lives in the UI layer so
hideUihosts are unaffected.Closes #3