fix: sync GeoId/GridId type unions with palette.js - #20
Merged
nmndwivedi merged 3 commits intoSep 19, 2026
Merged
Conversation
…d drift test - GeoId: add missing 'cloud' to match GEO_IDS - GridId: add missing 'ruled', 'crosses', 'iso' to match GRID_IDS - Update JSDoc comments in core, react, and react-native type declarations - README: list all seven geo shapes and six grid kinds, mark 'lines' as default - Add packages/core/test/type-drift.test.js to catch future union drift Fixes quickdrawjs#16 Co-authored-by: Dark <Dahhrk@users.noreply.github.com>
Co-authored-by: Dark <Dahhrk@users.noreply.github.com>
… default is lines Co-authored-by: Dark <Dahhrk@users.noreply.github.com>
|
@cursoragent is attempting to deploy a commit to the naman's projects Team on Vercel. A member of the Team first needs to authorize it. |
nmndwivedi
approved these changes
Sep 19, 2026
nmndwivedi
left a comment
nmndwivedi
left a comment
Collaborator
There was a problem hiding this comment.
Verified against palette.js — unions and docs now match GEO_IDS / GRID_IDS, and the drift test is a nice guard. Tests + typecheck pass on top of current main. Thanks!
nmndwivedi
marked this pull request as ready for review
September 19, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The type declarations in
packages/core/types/index.d.tsdrifted behind the runtime arrays inpalette.js:GeoIdwas missingcloudGridIdwas missingruled,crosses, andisopackages/core/README.mdlisted three grids and marked the default asnone; the default islinesThis PR aligns the unions, docs, and a CI drift test with the runtime source of truth.
Fixes #16
Changes
packages/core/types/index.d.tscloudonGeoId;ruled/crosses/isoonGridIdpackages/react/types/index.d.tspackages/react-native/types/index.d.tspackages/core/README.mdlinesmarked defaultREADME.mdlinespackages/core/test/type-drift.test.jsindex.d.tsand asserts they matchGEO_IDS/GRID_IDSNo lockfile change. No new runtime dependencies.